Skip to content

Bump up spotbugs version #2171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 2, 2020
Merged

Bump up spotbugs version #2171

merged 4 commits into from
Dec 2, 2020

Conversation

zoewangg
Copy link
Contributor

Description

Fix #2165

Motivation and Context

Testing

tested locally with JDK 15

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@codecov-io
Copy link

Codecov Report

Merging #2171 (231aec4) into master (668e773) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2171   +/-   ##
=========================================
  Coverage     77.44%   77.45%           
  Complexity      328      328           
=========================================
  Files          1222     1222           
  Lines         38301    38301           
  Branches       3018     3018           
=========================================
+ Hits          29663    29666    +3     
+ Misses         7183     7180    -3     
  Partials       1455     1455           
Flag Coverage Δ Complexity Δ
unittests 77.45% <ø> (+<0.01%) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...ine/stages/ApiCallAttemptTimeoutTrackingStage.java 93.10% <0.00%> (-6.90%) 0.00% <0.00%> (ø%)
...ty/internal/IdleConnectionCountingChannelPool.java 85.36% <0.00%> (-2.44%) 0.00% <0.00%> (ø%)
...ssdk/core/internal/async/FileAsyncRequestBody.java 84.76% <0.00%> (+3.80%) 0.00% <0.00%> (ø%)
...nio/netty/internal/OldConnectionReaperHandler.java 90.90% <0.00%> (+9.09%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 668e773...2ac1af5. Read the comment docs.

@zoewangg zoewangg merged commit 3a103f3 into master Dec 2, 2020
@zoewangg zoewangg deleted the zoewang/spotbugsVersionBump branch December 22, 2020 22:46
dagnir added a commit that referenced this pull request Oct 19, 2022
Fix mockito depdency for generated endpoint tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spotbugs Mojo injection error when building on JDK >= 14
3 participants