Event transformation based on type #2186
Merged
+46
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagnir
changed the base branch from
master
to
dongie/eventstream-visitors-fix
Codecov Report
@@ Coverage Diff @@
## dongie/eventstream-visitors-fix #2186 +/- ##
==================================================================
Coverage ? 77.53%
Complexity ? 328
==================================================================
Files ? 1228
Lines ? 38627
Branches ? 3034
==================================================================
Hits ? 29950
Misses ? 7216
Partials ? 1461
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Fixes event marshalling and unmarshalling: - Fix unmarshalling by mapping event type to the correct builder static constructor on the eventstream interface. - Fix marshalling by retrieving the value for the :event-type header from the event using getSdkEventType()
dagnir
force-pushed
the
event-marshalling-unmarshalling
branch
from
e648904 to
dac8179
Compare
|
Kudos, SonarCloud Quality Gate passed! |
zoewangg
approved these changes
Dec 4, 2020
dagnir
added a commit
that referenced
this pull request
Oct 19, 2022
- Fix expected exception types and messages - Fix some cases where endpoint override now does virtual addressing - Remove some broken tests - Comment out some currently broken tests because of issues in endpoint-rule-set.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes event marshalling and unmarshalling:
Fix unmarshalling by mapping event type to the correct builder static
constructor on the eventstream interface.
Fix marshalling by retrieving the value for the :event-type header from the
event using getSdkEventType()
Builds off #2176.
Motivation and Context
Bug fix.
Testing
Updated
codegenreference files.Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsLicense