Skip to content

Reverting #1971 as it was causing latency issues in test canaries #2236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Reverting #1971 as it was causing latency issues in test canaries #2236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/next-release/bugfix-AWSSDKforJavav2-da92594.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"category": "AWS SDK for Java v2",
"contributor": "",
"type": "bugfix",
"description": "Reverting synchronization of eventsToDeliver Object in onComplete() [PR#1971](https://github.com/aws/aws-sdk-java-v2/pull/1971) since it was causing latency."
}
4 changes: 1 addition & 3 deletions .../java/software/amazon/awssdk/awscore/eventstream/EventStreamAsyncResponseTransformer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,9 +394,7 @@ public void onError(Throwable throwable) {
@Override
public void onComplete() {
// Add the special on complete event to signal drainEvents to complete the subscriber
synchronized (eventsToDeliver) {
eventsToDeliver.add(ON_COMPLETE_EVENT);
}
eventsToDeliver.add(ON_COMPLETE_EVENT);
drainEventsIfNotAlready();
transformFuture.complete(null);
}
Expand Down