Skip to content

Use virtual host style on customizing endpoint #2333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

zmxnv1
Copy link

@zmxnv1 zmxnv1 commented Mar 14, 2021

Description

choose virtual host style when customize endpoint

Motivation and Context

#2317

Testing

Built locally

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@zmxnv1 zmxnv1 changed the title feat: choose virtual host style on customizing endpoint Use virtual host style on customizing endpoint Mar 15, 2021
@dagnir
Copy link
Contributor

dagnir commented Apr 8, 2021

Hi @zmxnv1, thank you for the contribution. I don't think this should be the behavior for all custom endpoints since this would be a breaking change. I think it makes sense for this feature to be gated behind a flag that a customer must enable.

@debora-ito
Copy link
Member

@zmxnv1 let us know if you want to continue working on this change in a non-breaking manner. Otherwise, this PR will auto close soon.

@debora-ito debora-ito added the closing-soon This issue will close in 4 days unless further comments are made. label May 20, 2021
@github-actions github-actions bot added closed-for-staleness and removed closing-soon This issue will close in 4 days unless further comments are made. labels May 24, 2021
@github-actions github-actions bot closed this May 24, 2021
aws-sdk-java-automation added a commit that referenced this pull request Jan 19, 2023
…eeace30c9

Pull request: release <- staging/68b9d81a-93df-4b81-a6c4-6aceeace30c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants