Skip to content

Add short type support #2387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

duy3101
Copy link
Contributor

@duy3101 duy3101 commented Apr 7, 2021

Description

Add short type support

Testing

mvn install

Screenshots (if appropriate)

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • [] I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • [] My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir
Copy link
Contributor

dagnir commented Apr 8, 2021

The change itself looks fine, but we should have some tests. I think it would be sufficient to add a protocol test, and a codegen test to ensure it works as expected. You can just add short types for the tests that have AllTypes like this one for the protocol tests, and here for the codegen tests

@codecov-io
Copy link

codecov-io commented Apr 9, 2021

Codecov Report

Merging #2387 (7d0c84c) into master (c7d5302) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2387      +/-   ##
============================================
+ Coverage     77.68%   77.69%   +0.01%     
  Complexity      366      366              
============================================
  Files          1246     1246              
  Lines         39338    39369      +31     
  Branches       3110     3110              
============================================
+ Hits          30560    30589      +29     
- Misses         7292     7293       +1     
- Partials       1486     1487       +1     
Flag Coverage Δ Complexity Δ
unittests 77.69% <100.00%> (+0.01%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...ware/amazon/awssdk/codegen/internal/TypeUtils.java 88.05% <100.00%> (+0.18%) 0.00 <0.00> (ø)
...ocols/json/internal/marshall/HeaderMarshaller.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...json/internal/marshall/JsonProtocolMarshaller.java 99.05% <100.00%> (+0.03%) 0.00 <0.00> (ø)
...s/json/internal/marshall/QueryParamMarshaller.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...on/internal/marshall/SimpleTypeJsonMarshaller.java 89.74% <100.00%> (+0.41%) 0.00 <0.00> (ø)
...on/internal/marshall/SimpleTypePathMarshaller.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...s/json/internal/unmarshall/HeaderUnmarshaller.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
.../internal/unmarshall/JsonProtocolUnmarshaller.java 95.83% <100.00%> (+0.08%) 0.00 <0.00> (ø)
...ery/internal/marshall/QueryProtocolMarshaller.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...y/internal/marshall/SimpleTypeQueryMarshaller.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7d5302...7d0c84c. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

93.9% 93.9% Coverage
0.0% 0.0% Duplication

@duy3101
Copy link
Contributor Author

duy3101 commented Apr 9, 2021

Closing this pr in favor of this #2395

@duy3101 duy3101 closed this Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants