Skip to content

Fix a race condition in FileAsyncRequestBody #2536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2021
Merged

Fix a race condition in FileAsyncRequestBody #2536

merged 1 commit into from
Jun 23, 2021

Conversation

zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Jun 16, 2021 •
edited
Loading

Description

Fix a race condition in FileAsyncRequestBody where a request demand comes in at the same time reading is progress, which causes the request to hang.

Motivation and Context

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@zoewangg zoewangg force-pushed the zoewang/fileAsyncRequestBodyRaceCondition branch from 559c18b to b20bc8f Compare June 18, 2021 00:01
@zoewangg zoewangg force-pushed the zoewang/fileAsyncRequestBodyRaceCondition branch from f2551af to 230c29e Compare June 21, 2021 22:18
@zoewangg zoewangg force-pushed the zoewang/fileAsyncRequestBodyRaceCondition branch from 230c29e to 1c3f90a Compare June 21, 2021 22:18
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

84.4% 84.4% Coverage
0.0% 0.0% Duplication

@zoewangg zoewangg merged commit b3923cb into feature/master/transfermanager Jun 23, 2021
@jmassiot jmassiot mentioned this pull request Jul 5, 2021
Closed
@zoewangg zoewangg deleted the zoewang/fileAsyncRequestBodyRaceCondition branch October 1, 2021 23:51
aws-sdk-java-automation pushed a commit that referenced this pull request Apr 24, 2023
@zoewangg
Merge pull request #2536 from aws/zoewang/ignoreServiceTest
90ecd69 
Remove test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagnir dagnir dagnir approved these changes

@millems millems millems approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zoewangg @dagnir @millems