Skip to content

Add validation in S3ClientConfiguration #2538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

zoewangg
Copy link
Contributor

Description

  • Add validation in S3ClientConfiguration
  • Add equals and hashcode
  • Add more tests

Motivation and Context

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@@ -479,6 +479,14 @@
</goals>
</execution>
</executions>
<configuration>
<excludes>
<exclude>software/amazon/awssdk/modulepath/tests/**/*.class</exclude>
Copy link
Contributor Author

@zoewangg zoewangg Jun 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to exclude test coverage reporting for test classes

@zoewangg zoewangg force-pushed the zoewang/s3ClientConfigurationValidation branch from 7504843 to 566b88a Compare June 17, 2021 01:58
@sonarqubecloud
Copy link

@zoewangg zoewangg merged commit 371b0ef into feature/master/transfermanager Jun 17, 2021
@zoewangg zoewangg deleted the zoewang/s3ClientConfigurationValidation branch June 17, 2021 17:41
aws-sdk-java-automation added a commit that referenced this pull request Apr 25, 2023
…9bf897f72

Pull request: release <- staging/ccfb5d5d-9383-4a28-af50-2ff9bf897f72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants