Add request cancellation logic and tests #2553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagnir
approved these changes
Jun 24, 2021
Comment on lines
2
to
15
| * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. Licensed under the Apache License, Version 2.0 | ||
| * (the "License"). You may not use this file except in compliance with the License. A copy of the License is | ||
| * located at http://aws.amazon.com/apache2.0 or in the "license" file accompanying this file. | ||
| * This file is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express | ||
| * or implied. See the License for the specific language governing permissions and limitations under the License. | ||
| */ | ||
|
|
There was a problem hiding this comment.
nit: this looks very strange, some characters looks like they're XML escaped
There was a problem hiding this comment.
Ha, good catch. There is a weird issue with my Intellij copyright profile. Will fix
zoewangg
force-pushed
the
zoewang/cancellation
branch
from
2764dbd to
c339ff7
Compare
|
Kudos, SonarCloud Quality Gate passed! |
aws-sdk-java-automation
added a commit
that referenced
this pull request
May 8, 2023
…ee30e6824 Pull request: release <- staging/edf479cc-a010-4e53-a02a-779ee30e6824
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add request cancellation logic and tests
Motivation and Context
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsLicense