Offload completion of execution future to a separate thread #2557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...transfer-manager/src/main/java/software/amazon/awssdk/transfer/s3/S3ClientConfiguration.java
Outdated
Show resolved
Hide resolved
...nager/src/main/java/software/amazon/awssdk/transfer/s3/internal/DefaultS3CrtAsyncClient.java
Outdated
Show resolved
Hide resolved
...nager/src/main/java/software/amazon/awssdk/transfer/s3/internal/DefaultS3CrtAsyncClient.java
Outdated
Show resolved
Hide resolved
...transfer-manager/src/main/java/software/amazon/awssdk/transfer/s3/S3ClientConfiguration.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/software/amazon/awssdk/transfer/s3/internal/S3NativeClientConfiguration.java
Show resolved
Hide resolved
...r/src/main/java/software/amazon/awssdk/transfer/s3/internal/S3NativeClientConfiguration.java
Outdated
Show resolved
Hide resolved
| int maxPoolSize = Math.max(64, processors * 2); | ||
| ThreadPoolExecutor executor = new ThreadPoolExecutor(corePoolSize, maxPoolSize, | ||
| 10, TimeUnit.SECONDS, | ||
| new LinkedBlockingQueue<>(1_000), |
There was a problem hiding this comment.
What are the pros and cons of LinkedBlockingQueue vs. SynchronousQueue here?
...c/test/java/software/amazon/awssdk/transfer/s3/internal/S3NativeClientConfigurationTest.java
Show resolved
Hide resolved
...c/test/java/software/amazon/awssdk/transfer/s3/internal/S3NativeClientConfigurationTest.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/software/amazon/awssdk/transfer/s3/internal/S3NativeClientConfiguration.java
Outdated
Show resolved
Hide resolved
utils/src/main/java/software/amazon/awssdk/utils/CompletableFutureUtils.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/software/amazon/awssdk/transfer/s3/internal/S3NativeClientConfiguration.java
Outdated
Show resolved
Hide resolved
...c/test/java/software/amazon/awssdk/transfer/s3/internal/S3NativeClientConfigurationTest.java
Show resolved
Hide resolved
zoewangg
force-pushed
the
zoewang/offloadCompletion
branch
from
45a9e4f to
2ce01a5
Compare
Bennett-Lynch
approved these changes
Jun 26, 2021
zoewangg
force-pushed
the
zoewang/offloadCompletion
branch
from
2ce01a5 to
005370e
Compare
|
Kudos, SonarCloud Quality Gate passed! |
aws-sdk-java-automation
added a commit
that referenced
this pull request
May 11, 2023
…9a62c5f9c Pull request: release <- staging/35a236a8-3c54-40fd-b3d8-e069a62c5f9c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Offload completion of execution future to a separate thread to prevent the CRT threads being blocked by complex operations in the completion chain of a completable future
Motivation and Context
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsLicense