-
Notifications
You must be signed in to change notification settings - Fork 916
Adding segment, totalSegments parameters in dynamodb-enhanced client to support parallel scan #2614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…o support parallel scan Note: DynamoDB local does not support parallel scan. So, this change was tested manually using integration test.
SonarCloud Quality Gate failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and a logical extension of the request (doesn't break the library conceptual precepts). Shame that we can't write a local DDB test for it. Only other thing I'd say is that if we didn't have a test to cover equals and hashcode for ScanEnhancedRequest, that is on us, but since you're touching it it'd be nice if you could add them to improve the code.
...hanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/model/ScanEnhancedRequest.java
Outdated
Show resolved
Hide resolved
...hanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/model/ScanEnhancedRequest.java
Outdated
Show resolved
Hide resolved
Hi SDK Team, Any update on merging this change to next release ? |
Thanks for your contribution, will merge as soon as possible. |
Hi, Can you please let me know when this will be merged ? |
Hi, I see some merge commits. But, not sure if it is actually merged. Can you please confirm ? |
I will merge today for a release tomorrow. |
SonarCloud Quality Gate failed. |
…6192379d2 Pull request: release <- staging/284b25b7-50f5-4e55-b011-8026192379d2
Adding segment, totalSegments parameters in dynamodb-enhanced client to support parallel scan.
Motivation and Context
This change is required to support parallel scan on dynamo-db table using enhanced-client.
Feature Request: #1851
Description
It allows sdk user to specify 'segment' and 'totalSegments' parameter in 'ScanEnhancedRequest' model.
Testing
I added unit tests wherever possible. DynamoDB local does not support parallel scan. So, the API flow was tested manually using integration test wherein I ran test to hit actual DDB in parallel using 5 threads and ensured the final outcome retrieved all the items after scan completes on all 5 threads.
Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsLicense