-
Notifications
You must be signed in to change notification settings - Fork 916
Adding SqsBatchManager interfaces and Refactoring core BatchManager with interfaces #2645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zoewangg
merged 17 commits into
aws:feature/master/automatic-request-batching
from
16lim21:feature/master/automatic-request-batching
Aug 9, 2021
Merged
Adding SqsBatchManager interfaces and Refactoring core BatchManager with interfaces #2645
zoewangg
merged 17 commits into
aws:feature/master/automatic-request-batching
from
16lim21:feature/master/automatic-request-batching
Aug 9, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tation into DefaultBatchManager
…DefaultBatchManager
…iguration into a batchmanager package
… adding override tags
…atchManager code was copied from the Sqs batch manager integration test
zoewangg
reviewed
Aug 5, 2021
...ices/sqs/src/main/java/software/amazon/awssdk/services/sqs/batchmanager/SqsBatchManager.java
Show resolved
Hide resolved
...ices/sqs/src/main/java/software/amazon/awssdk/services/sqs/batchmanager/SqsBatchManager.java
Show resolved
Hide resolved
...ices/sqs/src/main/java/software/amazon/awssdk/services/sqs/batchmanager/SqsBatchManager.java
Outdated
Show resolved
Hide resolved
...ices/sqs/src/main/java/software/amazon/awssdk/services/sqs/batchmanager/SqsBatchManager.java
Show resolved
Hide resolved
core/sdk-core/src/main/java/software/amazon/awssdk/core/batchmanager/BatchManager.java
Outdated
Show resolved
Hide resolved
core/sdk-core/src/main/java/software/amazon/awssdk/core/batchmanager/BatchManager.java
Outdated
Show resolved
Hide resolved
…s to public ones.
zoewangg
reviewed
Aug 5, 2021
core/sdk-core/src/main/java/software/amazon/awssdk/core/batchmanager/BatchManagerBuilder.java
Outdated
Show resolved
Hide resolved
...-core/src/main/java/software/amazon/awssdk/core/batchmanager/BatchOverrideConfiguration.java
Outdated
Show resolved
Hide resolved
core/sdk-core/src/main/java/software/amazon/awssdk/core/batchmanager/BatchManagerBuilder.java
Outdated
Show resolved
Hide resolved
core/sdk-core/src/main/java/software/amazon/awssdk/core/batchmanager/BatchManagerBuilder.java
Outdated
Show resolved
Hide resolved
core/sdk-core/src/main/java/software/amazon/awssdk/core/batchmanager/BatchManagerBuilder.java
Outdated
Show resolved
Hide resolved
...sqs/src/main/java/software/amazon/awssdk/services/sqs/batchmanager/SqsAsyncBatchManager.java
Outdated
Show resolved
Hide resolved
zoewangg
reviewed
Aug 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build failed because of a checkstyle error in sqs, otherwise lgtm
Kudos, SonarCloud Quality Gate passed! |
zoewangg
approved these changes
Aug 9, 2021
aws-sdk-java-automation
added a commit
that referenced
this pull request
Aug 7, 2023
…a1d26b9d5 Pull request: release <- staging/2bddec1a-c0a4-4e5a-9f56-5aea1d26b9d5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
I added interfaces for the core
BatchManager
to abstract away the private methods in the implementation. I also created the interfaces and class files for theSqsBatchManager
to prepare for implementation.Description
I added some interfaces in a new
batchmanager
package that is not internal and abstracts away the implementation details for the underlyingDefaultBatchManager
. Customers will therefore interact with the interfaces and classes in the publicbatchmanager
package as opposed to the internal one.Meanwhile, I modified the
BatchOverrideConfiguration
class to accept optional values, which would be filled in with default values by a coreBatchConfiguration
class. Services that implement aBatchManager
will not need to rely on thisBatchConfiguration
class, it is just there to ensure default values are provided in case customers implement their own service-specific batch manager.Finally, I added some classes and interfaces for the
SqsBatchManager
. The actual implementation has not been finished yet, nor has tests been written. Some code in theDefaultSqsBatchManager
are just the functions copied over from the Sqs batch manager integration test.Testing
Modifications to the core BatchManager are covered by tests in the last PR. No tests have been written yet for the SqsBatchManager but will be done in a separate PR covering implementation details.
Types of changes
Checklist
mvn install
succeedsLicense