Create a shared, project-level IntelliJ inspection profile #2655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 10, 2021 15:42
## Motivation Similar to how aws#2652 recently moved our code style & copyright configuration files to the project-level, we can also do the same for IntelliJ inspections. This has the benefit of keeping inspections in sync for all users, as well as automatically informing new users of our expected coding best practices. We do not currently have an existing inspection profile, so we will take this opportunity to start with a new, blank inspection profile. Users may then propose customizing the inspections via PRs, subject to the normal review process. Over time we will gravitate towards a shared inspection profile that we can all agree on. ## Modifications * Create a new, blank "AWS Java SDK 2.0" inspection profile * Update profiles_settings.xml to make users use this profile * Add corresponding gitignore update * Add corresponding GettingStarted update
## Motivation Similar to how aws#2652 recently moved our code style & copyright configuration files to the project-level, we can also do the same for IntelliJ inspections. This has the benefit of keeping inspections in sync for all users, as well as automatically informing new users of our expected coding best practices. We do not currently have an existing inspection profile, so we will take this opportunity to start with a new, blank inspection profile. Users may then propose customizing the inspections via PRs, subject to the normal review process. Over time we will gravitate towards a shared inspection profile that we can all agree on. ## Modifications * Create a new, blank "AWS Java SDK 2.0" inspection profile * Update profiles_settings.xml to make users use this profile * Add corresponding gitignore update * Add corresponding GettingStarted update
cenedhryn
approved these changes
Aug 10, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Similar to how #2652 recently
moved our code style & copyright configuration files to the
project-level, we can also do the same for IntelliJ inspections. This
has the benefit of keeping inspections in sync for all users, as well as
automatically informing new users of our expected coding best practices.
We do not currently have an existing inspection profile, so we will take
this opportunity to start with a new, blank inspection profile. Users
may then propose customizing the inspections via PRs, subject to the
normal review process. Over time we will gravitate towards a shared
inspection profile that we can all agree on.
Modifications
License