Skip to content

Implement ADAPTIVE Retry Mode #2658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Implement ADAPTIVE Retry Mode #2658

merged 1 commit into from
Aug 19, 2021

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented Aug 11, 2021

Motivation and Context

This PR introduces support for ADAPTIVE retry mode.

ADAPTIVE retry mode builds on top of STANDARD retry mode and includes rate
limiting of requests when the client is throttled.

Description

Implement ADAPTIVE retry mode. ADAPTIVE mode builds on STANDARD retry mode and adds rate limiting of requests when the client is throttled.

Adaptive retry mode dynamically limits the rate of AWS requests to maximize success rate. This may be at the expense of request latency. Adaptive retry mode is not recommended when predictable latency is important.

Testing

  • New unit tests
  • Running integ tests
  • Running stability tests

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir dagnir force-pushed the adaptive-retries branch 5 times, most recently from 432bdcf to 6272145 Compare August 12, 2021 21:20
@dagnir dagnir changed the title WIP Adaptive Retry Mode Implement ADAPTIVE Retry Mode Aug 12, 2021
@dagnir dagnir marked this pull request as ready for review August 12, 2021 22:21
ADAPTIVE retry mode builds on top of STANDARD retry mode and includes rate
limiting of requests when the client is throttled.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

96.7% 96.7% Coverage
0.0% 0.0% Duplication

@dagnir dagnir merged commit 855bba6 into aws:master Aug 19, 2021
@dagnir dagnir deleted the adaptive-retries branch August 19, 2021 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants