Skip to content

Clear env vars, sys props before test #2659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2021
Merged

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented Aug 11, 2021

Motivation and Context

Avoids picking up values that were set by other tests using the same env
variables and system properties.

Also use AssertJ matchers in tests.

Description

Testing

mvn clean install to make sure the tests pass.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

Avoids picking up values that were set by other tests using the same env
variables and system properties.

Also use AssertJ matchers in tests.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dagnir dagnir merged commit 5fb4475 into aws:master Aug 11, 2021
@dagnir dagnir deleted the fix-imds-test branch August 11, 2021 22:18
aws-sdk-java-automation added a commit that referenced this pull request Aug 14, 2023
…ffdae2eba

Pull request: release <- staging/7ad4b3b1-8ba2-448a-9d71-a10ffdae2eba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants