Add support for event stream requests over RPC #2662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 94f5744.
… stream types are sent with this content type.
|
Can you run the integ tests to make sure Transcribe is working? |
|
Transcribe Streaming and Kinesis integration tests pass. |
dagnir
approved these changes
Aug 12, 2021
|
Kudos, SonarCloud Quality Gate passed! |
aws-sdk-java-automation
added a commit
that referenced
this pull request
Aug 16, 2023
…f4ea1f07a Pull request: release <- staging/7c636434-0a13-49f3-b096-5f7f4ea1f07a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the revert in https://github.com/aws/aws-sdk-java-v2/pull/2451/files, which was done because the original change broke Lex's event streaming APIs: it changed the content-type in the event stream to application/x-amz-json-1.1, which Lex couldn't handle because it is a rest-json service.
This will no longer break Lex because of the second commit included in this customizing the content-type for Lex to application/json. This also affects non-event-streaming operations.
I verified that after this change, Lex's deleteSession (non-streaming) and startConversation (event streaming) APIs both work.
In the long-term, we should change the default content-type for all rest-json services to application/json and remove this customization, but that's a longer-term project.