-
Notifications
You must be signed in to change notification settings - Fork 916
Document support for Web Identity Token in DefaultCredentialsProvider #2667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing the docs @jamieliu386!
Kudos, SonarCloud Quality Gate passed!
|
@all-contributors please add @jamieliu386 for documentation |
I've put up a pull request to add @jamieliu386! 🎉 |
(Trying this again to see if the bot will create a fresh PR since #2674 now has merge conflicts) @all-contributors please add @jamieliu386 for documentation |
@jamieliu386 already contributed before to doc |
(Once more with PR closed) @all-contributors please add @jamieliu386 for documentation |
@jamieliu386 already contributed before to doc |
…b9267ecdc Pull request: release <- staging/dca3b8c0-2776-4b88-bdaf-672b9267ecdc
Motivation and Context
The Javadoc for
DefaultCredentialsProvider
lists the ways it tries to search for credentials in the surrounding environment. However, missing from the list is the support for STS Web Identity Tokens. TheDefaultCredentialsProvider
actually triesWebIdentityTokenFileCredentialsProvider
in between environment variables and profile files, as seen here:aws-sdk-java-v2/core/auth/src/main/java/software/amazon/awssdk/auth/credentials/DefaultCredentialsProvider.java
Lines 71 to 92 in 855bba6
Description
This PR adds information on the support for web identity tokens to the Javadoc for
DefaultCredentialsProvider
. Note that the 1.x SDK documentation already has this information.Testing
N/A
Screenshots (if appropriate)
N/A
Types of changes
Checklist
mvn install
succeedsLicense