Skip to content

Reduce base delay of STANDARD retry mode to 100ms for non-throttling responses. #2763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Reduce base delay of STANDARD retry mode to 100ms for non-throttling responses. #2763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/next-release/feature-AWSSDKforJavav2-64fda1c.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"category": "AWS SDK for Java v2",
"contributor": "",
"type": "feature",
"description": "Reduce base delay of STANDARD retry mode to 100ms for non-throttling responses. This reduces tail latency in the event of transient failures."
}
2 changes: 1 addition & 1 deletion ...core/src/main/java/software/amazon/awssdk/core/internal/retry/SdkDefaultRetrySetting.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public static final class Legacy {

public static final class Standard {
private static final int MAX_ATTEMPTS = 3;
private static final Duration BASE_DELAY = Duration.ofSeconds(1);
private static final Duration BASE_DELAY = Duration.ofMillis(100);
private static final Duration THROTTLED_BASE_DELAY = Duration.ofSeconds(1);
private static final int THROTTLE_EXCEPTION_TOKEN_COST = 5;
private static final int DEFAULT_EXCEPTION_TOKEN_COST = 5;
Expand Down
4 changes: 2 additions & 2 deletions core/sdk-core/src/test/java/software/amazon/awssdk/core/retry/RetryPolicyTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ public void standardRetryMode_shouldUseFullJitterOnly() {

assertThat(standardRetryPolicy.backoffStrategy()).isInstanceOf(FullJitterBackoffStrategy.class);
FullJitterBackoffStrategy backoffStrategy = (FullJitterBackoffStrategy) standardRetryPolicy.backoffStrategy();
assertThat(backoffStrategy.toBuilder().baseDelay()).isEqualTo(Duration.ofSeconds(1));
assertThat(backoffStrategy.toBuilder().baseDelay()).isEqualTo(Duration.ofMillis(100));
assertThat(backoffStrategy.toBuilder().maxBackoffTime()).isEqualTo(Duration.ofSeconds(20));

assertThat(standardRetryPolicy.throttlingBackoffStrategy()).isInstanceOf(FullJitterBackoffStrategy.class);
Expand All @@ -159,7 +159,7 @@ public void adaptiveRetryMode_shouldUseFullJitterOnly() {

assertThat(standardRetryPolicy.backoffStrategy()).isInstanceOf(FullJitterBackoffStrategy.class);
FullJitterBackoffStrategy backoffStrategy = (FullJitterBackoffStrategy) standardRetryPolicy.backoffStrategy();
assertThat(backoffStrategy.toBuilder().baseDelay()).isEqualTo(Duration.ofSeconds(1));
assertThat(backoffStrategy.toBuilder().baseDelay()).isEqualTo(Duration.ofMillis(100));
assertThat(backoffStrategy.toBuilder().maxBackoffTime()).isEqualTo(Duration.ofSeconds(20));

assertThat(standardRetryPolicy.throttlingBackoffStrategy()).isInstanceOf(FullJitterBackoffStrategy.class);
Expand Down
25 changes: 15 additions & 10 deletions ...rc/test/java/software/amazon/awssdk/core/retry/backoff/FullJitterBackoffStrategyTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,31 +44,36 @@ public static Collection<TestCase> parameters() throws Exception {
return Arrays.asList(
new TestCase().backoffStrategy(BackoffStrategy.defaultStrategy(RetryMode.STANDARD))
.retriesAttempted(0)
.expectedMaxDelay(Duration.ofSeconds(1))
.expectedMedDelay(Duration.ofMillis(500))
.expectedMaxDelay(Duration.ofMillis(100))
.expectedMedDelay(Duration.ofMillis(50))
.expectedMinDelay(Duration.ofMillis(1)),
new TestCase().backoffStrategy(BackoffStrategy.defaultStrategy(RetryMode.STANDARD))
.retriesAttempted(1)
.expectedMaxDelay(Duration.ofSeconds(2))
.expectedMedDelay(Duration.ofSeconds(1))
.expectedMaxDelay(Duration.ofMillis(200))
.expectedMedDelay(Duration.ofMillis(100))
.expectedMinDelay(Duration.ofMillis(1)),
new TestCase().backoffStrategy(BackoffStrategy.defaultStrategy(RetryMode.STANDARD))
.retriesAttempted(2)
.expectedMaxDelay(Duration.ofSeconds(4))
.expectedMedDelay(Duration.ofSeconds(2))
.expectedMaxDelay(Duration.ofMillis(400))
.expectedMedDelay(Duration.ofMillis(200))
.expectedMinDelay(Duration.ofMillis(1)),
new TestCase().backoffStrategy(BackoffStrategy.defaultStrategy(RetryMode.STANDARD))
.retriesAttempted(3)
.expectedMaxDelay(Duration.ofSeconds(8))
.expectedMedDelay(Duration.ofSeconds(4))
.expectedMaxDelay(Duration.ofMillis(800))
.expectedMedDelay(Duration.ofMillis(400))
.expectedMinDelay(Duration.ofMillis(1)),
new TestCase().backoffStrategy(BackoffStrategy.defaultStrategy(RetryMode.STANDARD))
.retriesAttempted(4)
.expectedMaxDelay(Duration.ofSeconds(16))
.expectedMedDelay(Duration.ofSeconds(8))
.expectedMaxDelay(Duration.ofMillis(1600))
.expectedMedDelay(Duration.ofMillis(800))
.expectedMinDelay(Duration.ofMillis(1)),
new TestCase().backoffStrategy(BackoffStrategy.defaultStrategy(RetryMode.STANDARD))
.retriesAttempted(5)
.expectedMaxDelay(Duration.ofMillis(3200))
.expectedMedDelay(Duration.ofMillis(1600))
.expectedMinDelay(Duration.ofMillis(1)),
new TestCase().backoffStrategy(BackoffStrategy.defaultStrategy(RetryMode.STANDARD))
.retriesAttempted(100)
.expectedMaxDelay(Duration.ofSeconds(20))
.expectedMedDelay(Duration.ofSeconds(10))
.expectedMinDelay(Duration.ofMillis(1))
Expand Down