Attempt to fix the flakiness of the codegen-generated-classes-test tests. #2769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millems
force-pushed
the
millem/fix-flakes-2
branch
from
ac0b7c8 to
e418313
Compare
zoewangg
reviewed
Oct 14, 2021
| if (t == null) { | ||
| responseFuture.complete(r); | ||
| responseFuture.complete(responseHandlerFuture.join()); |
There was a problem hiding this comment.
responseFuture.complete(r)?
There was a problem hiding this comment.
r is Void, since it's from CompletableFuture.allOf
| responseHandlerFuture.whenCompleteAsync((r, t) -> { | ||
| // When the response handler and HTTP client are done processing the request, use the future completion executor | ||
| // to complete the future returned by this function. | ||
| CompletableFuture.allOf(responseHandlerFuture, httpClientFuture).whenCompleteAsync((r, t) -> { |
There was a problem hiding this comment.
Hopefully there's no edge case where httpClientFuture never gets completed
zoewangg
approved these changes
Oct 14, 2021
millems
force-pushed
the
millem/fix-flakes-2
branch
from
7a4bd33 to
3d22cfe
Compare
…sts. I wasn't able to reproduce the error locally or in codebuild, which manifests as an index-out-of-bounds exception in BaseAsyncCoreMetricsTest>apiCall_allRetryAttemptsFailedOfNetworkError:108 for async sub-classes. This fixes one potential cause of the error: the result future for an operation can theoretically be completed before the metric gathering future (which is the HTTP call completion future). This change prevents completing the operation future until the HTTP call completion future is completed (in addition to the current future that's checked, the response handling future).
millems
force-pushed
the
millem/fix-flakes-2
branch
from
3d22cfe to
e07fed9
Compare
|
Kudos, SonarCloud Quality Gate passed! |
joviegas
approved these changes
Oct 14, 2021
aws-sdk-java-automation
added a commit
that referenced
this pull request
Nov 13, 2023
…fd6ef6db1 Pull request: release <- staging/507216cd-4b05-4879-ba95-a70fd6ef6db1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't able to reproduce the error locally or in codebuild, which manifests as an index-out-of-bounds exception in BaseAsyncCoreMetricsTest>apiCall_allRetryAttemptsFailedOfNetworkError:108 for async sub-classes.
This fixes one potential cause of the error: the result future for an operation can theoretically be completed before the metric gathering future (which is the HTTP call completion future). This change prevents completing the operation future until the HTTP call completion future is completed (in addition to the current future that's checked, the response handling future).