Skip to content

feat: Enable StsWebIdentityCredentialsProvider to be given a custom httpClient #2824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sroze
Copy link

@sroze sroze commented Nov 4, 2021

This enables to provide a custom SdkHttpClient to the web identity token file provider.

Motivation and Context

Running a Quarkus application in EKS, the application authenticates itself to AWS services with the WebIdentityTokenFileCredentialsProvider. For some reason, I can't get Quarkus to recognise the available HTTP client when built with the "native" profile so have to explicitly given the httpClient to the AWS clients. However, it doesn't work with this authentication provider because we can't give it our own HTTP client.

Description

This allows to pass down the httpClient from WebIdentityTokenFileCredentialsProvider to the STS client.

Testing

  • TODO.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@debora-ito
Copy link
Member

@sroze This PR has been in draft state for some time now, do you still want to proceed?

@debora-ito debora-ito added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 10 days. label May 9, 2022
@github-actions
Copy link

It looks like this PR has not been active for more than five days. In the absence of more information, we will be closing this PR soon. Please add a comment to prevent automatic closure, or if the PR is already closed please feel free to open a new one.

@github-actions github-actions bot added closing-soon This issue will close in 4 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will close in 4 days unless further comments are made. labels May 14, 2022
@github-actions github-actions bot closed this May 17, 2022
aws-sdk-java-automation added a commit that referenced this pull request Dec 1, 2023
…c2a3237d1

Pull request: release <- staging/6684b678-07ce-4a05-a034-865c2a3237d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-for-staleness response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 10 days.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants