Release endpoint variants: dualstack and fips for all services. #2830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joviegas
reviewed
Nov 9, 2021
| try (BufferedReader br = new BufferedReader(new InputStreamReader(allowListStream, StandardCharsets.UTF_8))) { | ||
| String line; | ||
| while ((line = br.readLine()) != null) { | ||
| DEPRECATED_REGIONS_ALLOWSLIST.add(line); |
There was a problem hiding this comment.
Non Blocker : Query :
Should we do a trim(line) or normalize the line here ?
joviegas
approved these changes
Nov 9, 2021
…ALSTACK.
This adds the ability to resolve fips and dualstack endpoints with a "fips enabled" or "dualstack enabled" flag.
E.g.
```java
URI fipsEndpoint =
ServiceMetadata.of(S3Client.SERVICE_METADATA_ID)
.endpointFor(ServiceEndpointKey.builder()
.region(Region.US_WEST_2)
.tags(EndpointTag.FIPS)
.build());
```
The following public API changes were made:
1. Added `ServiceMetadata.endpointFor(ServiceEndpointKey)`
2. Added `ServiceMetadata.signingRegion(ServiceEndpointKey)`
3. Added `PartitionMetadata.hostname(PartitionEndpointKey)`
4. Added `PartitionMetadata.dnsSuffix(PartitionEndpointKey)`
5. Added a generated `EndpointTag` class, which currently contains FIPS and DUALSTACK.
6. Removed `ServiceMetadata.computeEndpoint`, because it shouldn't have ever been public, and no one should be using it.
The following module changes were made:
1. Added `regions-testing` for verifying region resolution behavior that doesn't currently exist in the endpoints.json
This option can be used to make calls be invoked against AWS endpoints which return IPv6 records. This can also be enabled via the `AWS_USE_DUALSTACK_ENDPOINT` environment variable, `aws.useDualstackEndpoint` system property, or the `use_dualstack_endpoint` profile file property: 1. This PR builds on top of the 'endpoint variants' #2808, by specifying the DUALSTACK endpoint variant whenever the customer requests dualstack to be enabled. 2. The bulk of the files in this PR are addressing the fact that we already have service configuration for enabling dualstack for S3 and S3 control. These existing options have been deprecated in favor of the new option that works for all services.
This option can be used to make calls be invoked against FIPS-compliant AWS endpoints. This can also be enabled via the AWS_USE_FIPS_ENDPOINT environment variable, aws.useFipsEndpoint system property, or the use_fips_endpoint profile file property:
millems
force-pushed
the
endpoint-tag-staging-rebased
branch
from
0a84955 to
2ec1faa
Compare
|
Kudos, SonarCloud Quality Gate passed! |
aws-sdk-java-automation
added a commit
that referenced
this pull request
Dec 8, 2023
…5bd8d99f7 Pull request: release <- staging/841ca519-19c3-42be-a683-9e85bd8d99f7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes were already code reviewed:
dualstackEnabledproperty to every client builder. #2818This pull request is just for a rebase from master, and releasing the changes.