Adds DNS resolver configuration option for ApacheHttpClient #2834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagnir
reviewed
Nov 9, 2021
| @@ -0,0 +1,6 @@ | |||
| { | |||
| "category": "AWS SDK for Java v2", | |||
There was a problem hiding this comment.
Since this is specific to Apache, we should change this to the Apache client
| overrideDnsResolver("sad.local.host"); | ||
| } | ||
|
|
||
| private void overrideDnsResolver(String hostName) throws IOException { |
There was a problem hiding this comment.
It's used for the URI a bit further down
| @@ -123,4 +126,23 @@ public void credentialProviderCanBeUsedWithProxy() { | |||
| .credentialsProvider(Mockito.mock(CredentialsProvider.class)) | |||
| .build(); | |||
| } | |||
|
|
|||
| @Test | |||
| public void dnsResolverCanBeUsed() { | |||
There was a problem hiding this comment.
can we add a test that if the caller explicitly sets to null we use the default resolver?
cenedhryn
force-pushed
the
salande/dns-resolver-override
branch
from
12227be to
bd68a87
Compare
dagnir
approved these changes
Nov 10, 2021
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Implements a feature requested in #2627
Description
Allows users to set a custom DNS resolver to be used for the Apache Http Client.
Types of changes
Checklist
mvn installsucceedsLicense