Bump up CRT version #2836
Merged
Bump up CRT version #2836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
force-pushed
the
zoewang/crt0.15.8
branch
from
8997d73 to
f490913
Compare
zoewangg
force-pushed
the
zoewang/crt0.15.8
branch
from
e6aab46 to
4a5de14
Compare
Bennett-Lynch
approved these changes
Nov 10, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
aws-sdk-java-automation
added a commit
that referenced
this pull request
Dec 14, 2023
…4209ebdc3 Pull request: release <- staging/7b27dac6-6957-4cda-a494-7e94209ebdc3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump up CRT version that has fix for #2774 via awslabs/aws-crt-java#402
Had to set the TLS version explicitly to make the test pass because the test fails with TLS 1.3The existing CRT H1ServerBehaviorTest.java fails with Java 11 when TLS 1.3 is used, changed to use openssl instead.
The tests use CRT HTTP client (s2n TLS implementation) to send requests to a local netty mock server. With the previous CRT version 0.15.7, the negotiated version is TLS 1.2 on CodeBuild and the tests pass. With the new CRT 0.15.8, the TLS version is 1.3 and the negotiation fails when the server uses Java TLS implementation.