Skip to content

Make ProcessCredentialsProvider closeable, so that the internal cre… #2838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 10, 2021

Conversation

millems
Copy link
Contributor

@millems millems commented Nov 10, 2021

…dentials cache (which may be async and need to be closed) can be closed. I also verified that this is the only usage of CachedSupplier that is affected.

@millems millems requested a review from a team as a code owner November 10, 2021 18:04
…dentials cache (which may be async and need to be closed) can be closed. I also verified that this is the only usage of CachedSupplier that is affected.
@millems millems force-pushed the millem/make-process-credentials-provider-closeable branch from 46e466d to 845d8f0 Compare November 10, 2021 18:11
@millems millems enabled auto-merge (squash) December 10, 2021 18:51
@millems millems merged commit b1dbeff into master Dec 10, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@millems millems deleted the millem/make-process-credentials-provider-closeable branch October 19, 2022 19:36
aws-sdk-java-automation added a commit that referenced this pull request Dec 18, 2023
…e7385110d

Pull request: release <- staging/74bad4b8-aa72-46fb-b407-774e7385110d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants