Adds all fields in RequestOverrideConfiguration in toBuilder #2862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagnir
approved these changes
Nov 19, 2021
| .addMetricPublisher(mock(MetricPublisher.class)) | ||
| .build(); | ||
|
|
||
| assertThat(configuration.toBuilder().build()).isEqualTo(configuration); |
There was a problem hiding this comment.
Could we use something like usingRecursiveComparison() here?
https://assertj.github.io/doc/#assertj-core-recursive-comparison
Or does the combination of EqualsVerifier and isEqualTo provide similar guarantees?
There was a problem hiding this comment.
In this situation they yield similar results, but I do like the more verbose output of usingRecursiveComparison()
…ated from an instance
cenedhryn
force-pushed
the
salande/metrics-with-paginatin
branch
from
6fde02c to
5841de1
Compare
Bennett-Lynch
approved these changes
Nov 20, 2021
| .addMetricPublisher(mock(MetricPublisher.class)) | ||
| .build(); | ||
|
|
||
| assertThat(configuration.toBuilder().build()).usingRecursiveComparison().isEqualTo(configuration); |
There was a problem hiding this comment.
It would be nice if we could find a way to enforce this validation for all of our classes that implement toBuilder().
|
Kudos, SonarCloud Quality Gate passed! |
aws-sdk-java-automation
added a commit
that referenced
this pull request
Jan 17, 2024
…4e66acdd3 Pull request: release <- staging/f218cb95-de05-40e5-a8fa-3d64e66acdd3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When a
requestOverrideConfigurationis modified from an existing instance all values of existing fields should be copied. For instance,metricPublisherswas missing, leading to the paginated operations code path missing metric publishers added as a request override and no metrics are published.Description
Updated the
BuilderImplconstructor that takes aRequestOverrideConfigurationas an argument.Testing
Types of changes
Checklist
mvn installsucceedsLicense