Massage S3 test bucket name to avoid underscores

[ybuzko]

Massage S3 test bucket name to avoid underscores

Motivation and Context

In S3BucketUtils, there is a helper function temporaryBucketName that produces a temporary bucket name for unit and integration tests. It uses system username as part of the concatenation. In some OS (Windows, maybe others), underscore is an allowed character (in fact, Windows 10 auto-creates usernames with underscores in the middle). S3 bucket names do not allow underscores. Thus, any S3 unit tests fail on Windows.

Description

Adding a call to replace underscores with dashes in the username component of the generated bucket name.

Testing

1. Executed a unit test that includes a call to temporaryBucketName(), and subsequent creation of a test S3 bucket with that name, on Windows 10. It failed due to my username having an underscore.
2. Made the change.
3. Re-ran the test. Bucket creation succeeded.

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Checklist

• I have read the CONTRIBUTING document
• Local run of mvn install succeeds
• My code follows the code style of this project
• My change requires a change to the Javadoc documentation
• I have updated the Javadoc documentation accordingly
• I have read the README document
• I have added tests to cover my changes
• All new and existing tests passed
• A short description of the change has been added to the CHANGELOG
• My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

• I confirm that this pull request can be released under the Apache 2 license

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication