Skip to content

If tlsNegotiationTimeout is not configured, it will be resolved as th… #2917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 14, 2021
Merged

If tlsNegotiationTimeout is not configured, it will be resolved as th… #2917

merged 5 commits into from
Dec 14, 2021

Conversation

zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Dec 13, 2021 •
edited
Loading

…e connectTimeout

Motivation and Context

The current tlsNegotiationTimeout is too conservative.

Description

If tlsNegotiationTimeout is not configured, it will be set to the resolved connectionTimeout

Testing

Added unit tests

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@zoewangg zoewangg requested a review from a team as a code owner December 13, 2021 20:45
Bennett-Lynch
Bennett-Lynch reviewed Dec 14, 2021
View reviewed changes
@zoewangg zoewangg enabled auto-merge (squash) December 14, 2021 18:06
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

77.8% 77.8% Coverage
0.0% 0.0% Duplication

@zoewangg zoewangg merged commit ad29dd4 into master Dec 14, 2021
@zoewangg zoewangg deleted the zoewang/resolvedTlsTimeout branch February 15, 2022 22:13
aws-sdk-java-automation added a commit that referenced this pull request Mar 6, 2024
@aws-sdk-java-automation
Merge pull request #2917 from aws/staging/bad2b06d-14c1-496d-9262-4c3…
050eb66 
…262a5d99a

Pull request: release <- staging/bad2b06d-14c1-496d-9262-4c3262a5d99a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bennett-Lynch Bennett-Lynch Bennett-Lynch approved these changes

@joviegas joviegas joviegas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zoewangg @Bennett-Lynch @joviegas