Upgrade Netty version from 4.1.68 to 4.1.72

[Bennett-Lynch]

Upgrade Netty version from 4.1.68 to 4.1.72.

1. https://netty.io/news/2021/10/11/4-1-69-Final.html
2. https://netty.io/news/2021/10/11/4-1-70-Final.html
3. https://netty.io/news/2021/12/09/4-1-71-Final.html
4. https://netty.io/news/2021/12/13/4-1-72-Final.html

License

• I confirm that this pull request can be released under the Apache 2 license

[Bennett-Lynch]

Needed to support the change in behavior introduced by netty/netty@ef1f637:

java.lang.ClassCastException: software.amazon.awssdk.http.nio.netty.internal.nrs.HandlerSubscriberTest$CustomEmbeddedEventLoop cannot be cast to io.netty.channel.embedded.EmbeddedEventLoop
--
at software.amazon.awssdk.http.nio.netty.internal.nrs.HandlerSubscriberTest.teardown(HandlerSubscriberTest.java:69)
 
[System Output]
2021-12-15 16:41:35,290 [main] WARN  io.netty.channel.embedded.EmbeddedChannel - More than one exception was raised. Will report only the first one and log others.
java.lang.ClassCastException: software.amazon.awssdk.http.nio.netty.internal.nrs.HandlerSubscriberTest$CustomEmbeddedEventLoop cannot be cast to io.netty.channel.embedded.EmbeddedEventLoop
at io.netty.channel.embedded.EmbeddedChannel.embeddedEventLoop(EmbeddedChannel.java:680)
at io.netty.channel.embedded.EmbeddedChannel.runPendingTasks(EmbeddedChannel.java:602)
at io.netty.channel.embedded.EmbeddedChannel$EmbeddedUnsafe$1.beginRead(EmbeddedChannel.java:842)
at io.netty.channel.DefaultChannelPipeline$HeadContext.read(DefaultChannelPipeline.java:1362)
at io.netty.channel.AbstractChannelHandlerContext.invokeRead(AbstractChannelHandlerContext.java:686)
at io.netty.channel.AbstractChannelHandlerContext.read(AbstractChannelHandlerContext.java:671)
at io.netty.channel.DefaultChannelPipeline.read(DefaultChannelPipeline.java:1004)
at io.netty.channel.AbstractChannel.read(AbstractChannel.java:290)
at io.netty.channel.DefaultChannelPipeline$HeadContext.readIfIsAutoRead(DefaultChannelPipeline.java:1422)
at io.netty.channel.DefaultChannelPipeline$HeadContext.channelActive(DefaultChannelPipeline.java:1400)
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelActive(AbstractChannelHandlerContext.java:230)
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelActive(AbstractChannelHandlerContext.java:216)
at io.netty.channel.DefaultChannelPipeline.fireChannelActive(DefaultChannelPipeline.java:895)
at io.netty.channel.AbstractChannel$AbstractUnsafe.register0(AbstractChannel.java:522)
at io.netty.channel.AbstractChannel$AbstractUnsafe.register(AbstractChannel.java:480)
at io.netty.channel.embedded.EmbeddedChannel$EmbeddedUnsafe$1.register(EmbeddedChannel.java:799)
at software.amazon.awssdk.http.nio.netty.internal.nrs.HandlerSubscriberTest$CustomEmbeddedEventLoop.register(HandlerSubscriberTest.java:195)
at software.amazon.awssdk.http.nio.netty.internal.nrs.HandlerSubscriberTest$CustomEmbeddedEventLoop.register(HandlerSubscriberTest.java:189)
at software.amazon.awssdk.http.nio.netty.internal.nrs.HandlerSubscriberTest.setup(HandlerSubscriberTest.java:61)

https://github.com/netty/netty/blob/11ba4cbdd5767b4f0fbb893880d255588d1067e6/transport/src/main/java/io/netty/channel/embedded/EmbeddedChannel.java#L680

[Bennett-Lynch]

Motivated by build failure:

[INFO] --- maven-dependency-plugin:3.1.1:analyze-only (default) @ netty-nio-client ---
[WARNING] Used undeclared dependencies found:
[WARNING]    io.netty:netty-transport-classes-epoll:jar:4.1.72.Final:compile
[WARNING] Unused declared dependencies found:
[WARNING]    io.netty:netty-transport-native-epoll:jar:linux-x86_64:4.1.72.Final:compile

[eejbyfeldt]

Is the dependency netty-transport-classes-epoll really useful without one version of netty-transport-native-epoll which contains the native library use by netty-transport-classes-epoll? Or are user expected to add their own dependency on netty-transport-classes-epoll?

[lokanx]

Any plans to merge and release this PR soon?

[Bennett-Lynch]

Hi @lokanx. I will try to get this PR merged and released soon. It is currently blocked on some additional testing.

If you have an urgent need to upgrade your consumed Netty version before the SDK change is released, you can also explicitly declare the version of Netty that you would like to use, rather than relying on the SDK's transitive dependency. Minor/patch version increases should generally be backwards compatible. An example of doing that with Maven can be found here and with Gradle can be found here.

That said, I understand this may not be a convenient option for all users, and they may still prefer the SDK to pull in the preferred version, so I will continue to prioritize this.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[Bennett-Lynch]

Released on 2022-01-07 as part of version 2.17.107.