Skip to content

Bump httpcore version to 4.4.13 #2928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 17, 2021
Merged

Bump httpcore version to 4.4.13 #2928

merged 2 commits into from
Dec 17, 2021

Conversation

linzebing
Copy link
Contributor

As title.

Motivation and Context

Fixes #2927

Description

Upgrade httpcomponents:httpcore version from 4.4.11 to 4.4.13

Testing

Build and existing tests

Screenshots (if appropriate)

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@linzebing linzebing requested a review from a team as a code owner December 15, 2021 20:42
@linzebing
Copy link
Contributor Author

@zoewangg : can you help take a look?

@zoewangg
Copy link
Contributor

Hi @linzebing, thank you for submitting the PR! We will take a look shortly

@@ -160,7 +160,7 @@

<jre.version>1.8</jre.version>
<httpcomponents.httpclient.version>4.5.13</httpcomponents.httpclient.version>
<httpcomponents.httpcore.version>4.4.11</httpcomponents.httpcore.version>
<httpcomponents.httpcore.version>4.4.13</httpcomponents.httpcore.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we may also need to upgrade org.apache.httpcomponents:httpclient too as org.apache.httpcomponents:httpclient:4.5.13 is depending on org.apache.httpcomponents:httpcore:4.4.13 #2927

Honestly I hope the aws-sdk-java-team can offer a complete solution to this issue in the future :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the latest version of org.apache.httpcomponents:httpclient in Maven is still 4.5.13. https://mvnrepository.com/artifact/org.apache.httpcomponents/httpclient Does that mean the enforcer plugin will prevent users from using the latest httpcore simply because the latest httpclient does not depend on the latest httpcore? Hmm, wouldn't it defeat the purpose?

Anyway, we can merge this PR. As to a solution, I think this should be addressed on the Apache HTTP Client side, if they introduce something like BOM, it would definitely help all consumers. For us, the only thing I can think of is to add a reminder note here to update httpcore whenever we update httpclient.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the enforcer rule just detects version conflicts:) (not a maven expert). Thanks for taking a look!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@zoewangg
Copy link
Contributor

Integ tests and stability tests passed.

@zoewangg zoewangg merged commit de1c53a into aws:master Dec 17, 2021
aws-sdk-java-automation pushed a commit that referenced this pull request Mar 18, 2024
…b72b1471e

Pull request: release <- staging/ead1306b-e72c-47d2-884e-cb7b72b1471e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade httpcomponents:httpcore version from 4.4.11 to 4.4.13
2 participants