-
Notifications
You must be signed in to change notification settings - Fork 916
Bump httpcore version to 4.4.13 #2928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@zoewangg : can you help take a look? |
Hi @linzebing, thank you for submitting the PR! We will take a look shortly |
@@ -160,7 +160,7 @@ | |||
|
|||
<jre.version>1.8</jre.version> | |||
<httpcomponents.httpclient.version>4.5.13</httpcomponents.httpclient.version> | |||
<httpcomponents.httpcore.version>4.4.11</httpcomponents.httpcore.version> | |||
<httpcomponents.httpcore.version>4.4.13</httpcomponents.httpcore.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we upgrade to the latest version 4.4.15?
https://downloads.apache.org/httpcomponents/httpcore/RELEASE_NOTES-4.4.x.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then we may also need to upgrade org.apache.httpcomponents:httpclient
too as org.apache.httpcomponents:httpclient:4.5.13
is depending on org.apache.httpcomponents:httpcore:4.4.13
#2927
Honestly I hope the aws-sdk-java-team can offer a complete solution to this issue in the future :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the latest version of org.apache.httpcomponents:httpclient
in Maven is still 4.5.13. https://mvnrepository.com/artifact/org.apache.httpcomponents/httpclient Does that mean the enforcer plugin will prevent users from using the latest httpcore simply because the latest httpclient does not depend on the latest httpcore? Hmm, wouldn't it defeat the purpose?
Anyway, we can merge this PR. As to a solution, I think this should be addressed on the Apache HTTP Client side, if they introduce something like BOM, it would definitely help all consumers. For us, the only thing I can think of is to add a reminder note here to update httpcore whenever we update httpclient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the enforcer rule just detects version conflicts:) (not a maven expert). Thanks for taking a look!
Kudos, SonarCloud Quality Gate passed!
|
Integ tests and stability tests passed. |
…b72b1471e Pull request: release <- staging/ead1306b-e72c-47d2-884e-cb7b72b1471e
As title.
Motivation and Context
Fixes #2927
Description
Upgrade httpcomponents:httpcore version from 4.4.11 to 4.4.13
Testing
Build and existing tests
Screenshots (if appropriate)
N/A
Types of changes
Checklist
mvn install
succeedsLicense