Log request ID and extended request ID with the requestId logger and … #2929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
force-pushed
the
zoewang/requestLogger
branch
from
f44dd0a to
759be4e
Compare
millems
reviewed
Dec 17, 2021
| @@ -94,6 +95,7 @@ public AwsXmlPredicatedResponseHandler( | |||
|
|
|||
| AwsXmlUnmarshallingContext parsedResponse = parseResponse(httpResponse, executionAttributes); | |||
| parsedResponse = decorateContextWithError.apply(parsedResponse); | |||
| logRequestId(httpResponse); | |||
There was a problem hiding this comment.
Is this not handled by the combined response handler below?
There was a problem hiding this comment.
Yeah, it seems AwsXmlPredicatedResponseHandler is used by s3, and combined response handler is used by all other services. (I just learned it yesterday)
| @@ -68,6 +69,8 @@ public CombinedResponseHandler(HttpResponseHandler<OutputT> successResponseHandl | |||
| ExecutionAttributes executionAttributes) | |||
| throws IOException, InterruptedException { | |||
|
|
|||
| logRequestId(httpResponse); | |||
There was a problem hiding this comment.
Any specific reason to have picked this response handler to do the logging?
There was a problem hiding this comment.
This is where we log the response status code currently, so I just included the request ID here
millems
approved these changes
Dec 17, 2021
|
Kudos, SonarCloud Quality Gate passed! |
aws-sdk-java-automation
added a commit
that referenced
this pull request
Mar 19, 2024
…2012b8724 Pull request: release <- staging/b6832892-c2e4-4c09-a766-b572012b8724
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…request logger
Motivation and Context
#2876
Description
Log request ID and extended request ID with the requestId logger and
Testing
Tested locally.
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsLicense