-
Notifications
You must be signed in to change notification settings - Fork 916
Support S3 SelectObjectContent #2943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This adds support for S3's SelectObjectContent operation by enabling operations with EventStreams as output for the XML protocol.
b8b64e5
to
56fc6ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome PR description!
services/s3/src/it/java/software/amazon/awssdk/services/SelectObjectContentIntegrationTest.java
Show resolved
Hide resolved
services/s3/src/it/java/software/amazon/awssdk/services/SelectObjectContentIntegrationTest.java
Outdated
Show resolved
Hide resolved
services/s3/src/it/java/software/amazon/awssdk/services/SelectObjectContentIntegrationTest.java
Show resolved
Hide resolved
...c/test/resources/software/amazon/awssdk/codegen/poet/client/test-xml-async-client-class.java
Outdated
Show resolved
Hide resolved
...c/test/resources/software/amazon/awssdk/codegen/poet/client/test-xml-async-client-class.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we kick off integration tests if we haven't already?
Yes, integ tests are passing with the revision before the changelog change. Kicked off another one so it's running for this latest revision. |
Kudos, SonarCloud Quality Gate passed! |
…85999c7f1 Pull request: release <- staging/c921135c-abdf-4c1d-a424-09385999c7f1
Motivation and Context
Parity with V1, which supports
SelectObjectContent
.Fixes #859
Description
This adds support for S3's SelectObjectContent operation by enabling operations
with EventStreams as output for the XML protocol.
Testing
REST-XML
services (route53
andcloudfront
) to make sure they're unaffected.Diffs for REST-XML services
Route53, CloudFront, and S3 were generated with the changes in this PR and without the changes, and then the two sets of files were compared. Route53 and CloudFront only have cosmetic changes.
S3Async Interface
DefaultS3AsyncClient
Route53
CloudFront
Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsLicense