Update Apache to not reuse connections if they received a 5xx error. #2960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagnir
approved these changes
Jan 11, 2022
zoewangg
approved these changes
Jan 11, 2022
| @@ -144,6 +144,30 @@ public void connectionPoolingWorks() throws Exception { | |||
| assertThat(CONNECTION_COUNTER.openedConnections()).isEqualTo(initialOpenedConnections + 1); | |||
| } | |||
|
|
|||
| @Test | |||
| public void connectionsAreNotReusedOn5xxErrors() throws Exception { | |||
This was already the behavior for Netty, and cannot be made the behavior for the URL connection client.
millems
force-pushed
the
millem/kill-5xx-connections
branch
from
50b0e97 to
a80e2fe
Compare
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was already the behavior for Netty, and cannot be made the behavior for the URL connection client.