Support zero-length chunked-encoded responses from XML services. #2964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code currently only considers responses with a content-length of zero as being empty. That isn't sufficient for chunk-encoded responses, which do not have a content-length. This change updates the logic to instead read a single byte off of the response stream to see if it's empty. This works for both zero content-length and empty chunked encoding streams.
cenedhryn
approved these changes
Jan 13, 2022
|
Kudos, SonarCloud Quality Gate passed! |
aws-sdk-java-automation
added a commit
that referenced
this pull request
Apr 10, 2024
…6a40dff07 Pull request: release <- staging/212738eb-72f0-4eb7-b258-89e6a40dff07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code currently only considers responses with a content-length of zero as being empty. That isn't sufficient for chunk-encoded responses, which do not have a content-length. This change updates the logic to instead read a single byte off of the response stream to see if it's empty. This works for both zero content-length and empty chunked encoding streams.