Skip to content

Set tableSchema to chained extensions read context #2971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 19, 2022
Merged

Set tableSchema to chained extensions read context #2971

merged 2 commits into from
Jan 19, 2022

Conversation

alvinsee
Copy link
Contributor

@alvinsee alvinsee commented Jan 14, 2022 •
edited
Loading

Motivation and Context

DynamoDB Enhanced Client allows custom extensions to be installed. However, the behavior of the meta extension ChainExtension differs when providing a DefaultDynamoDbExtensionContext to each extension's invocation of afterRead. The default behavior for a single extension (by ways of VersionRecordExtension) passes in the table schema to the builder. However, when two or more extensions are specified, ChainExtension omits the table schema entirely when it does the delegation. This breaks any custom extension that might require inferring the table schema in a read operation.

Description

  • sets tableSchema field when provisioning the extension context in ChainExtension#afterRead

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@alvinsee alvinsee requested a review from a team as a code owner January 14, 2022 23:49
zoewangg
zoewangg reviewed Jan 18, 2022
View reviewed changes
Copy link
Contributor

@zoewangg zoewangg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting the PR. LGTM. Could you add a changelog entry? You can do so by running the scripts/new-change script, following the instructions and then committing the new file created by the script in .changes/next-release with your changes.

@alvinsee alvinsee force-pushed the alvinsee/dynamodb-client-chained branch from 0fceefa to d4e5d4a Compare January 18, 2022 23:27
@alvinsee
Copy link
Contributor Author

Thank you for submitting the PR. LGTM. Could you add a changelog entry? You can do so by running the scripts/new-change script, following the instructions and then committing the new file created by the script in .changes/next-release with your changes.

Pushed up the requested change @zoewangg. Thanks!

zoewangg
zoewangg approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@zoewangg zoewangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@zoewangg zoewangg mentioned this pull request Jan 19, 2022
Closed
@zoewangg zoewangg enabled auto-merge (squash) January 19, 2022 19:41
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@zoewangg zoewangg merged commit 154a152 into aws:master Jan 19, 2022
@alvinsee alvinsee deleted the alvinsee/dynamodb-client-chained branch January 19, 2022 21:01
@zoewangg
Copy link
Contributor

@all-contributors please add @alvinsee for code

@allcontributors allcontributors bot mentioned this pull request Jan 19, 2022
Merged
@allcontributors
Copy link
Contributor

@zoewangg

I've put up a pull request to add @alvinsee! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoewangg zoewangg zoewangg approved these changes

@HadeelElbitar HadeelElbitar HadeelElbitar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alvinsee @zoewangg @HadeelElbitar