Revert the rollback of #2957 #2982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return false; | ||
| } | ||
|
|
||
| return false; |
There was a problem hiding this comment.
Should return true -- can we add a test case?
There was a problem hiding this comment.
hah, we actually have one. It would help if I ran it....
millems
force-pushed
the
millem/fix-s3-head-object
branch
from
445d853 to
2bebabe
Compare
Bennett-Lynch
approved these changes
Jan 21, 2022
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2957 was rolled back because it did not account for HEAD responses, and broke for S3 integration tests. This fixes that issue: Do not validate content-length for 304 and HEAD responses.
This PR is separated into two different commits so it's easier to ignore the previously-reviewed code and the fixes to that code.