Improve availability of instance profile credentials provider during outages. #2989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millems
force-pushed
the
millem/imds-improvements
branch
from
e518f6b to
555302c
Compare
zoewangg
reviewed
Jan 26, 2022
...rc/main/java/software/amazon/awssdk/auth/credentials/InstanceProfileCredentialsProvider.java
Show resolved
Hide resolved
...rc/main/java/software/amazon/awssdk/auth/credentials/InstanceProfileCredentialsProvider.java
Show resolved
Hide resolved
millems
force-pushed
the
millem/imds-improvements
branch
from
555302c to
5c0b81e
Compare
zoewangg
approved these changes
Jan 27, 2022
…outages. This is done by allowing services to validate credential expiration time during IMDS outages instead of assuming the SDK has access to the latest valid expiration time. Additional changes: 1. Removed unnecessary intellij inspections that have frequent false positives. 2. Include SDK user-agent in container credential provider calls. 3. Allow specifying the profile file and name used by the instance profile credentials provider. 4. Use the client's profile file and name for instance profile credentials when the default credentials provider is not overridden. 5. Convert the HttpCredentialsProvider protected API to a public API (with some breaking changes), so that there's fewer public classes extending internal classes.
millems
force-pushed
the
millem/imds-improvements
branch
from
5c0b81e to
52502b6
Compare
|
Closing without merging, because this will be merged in the future. |
|
SonarCloud Quality Gate failed. |
|
Kudos, SonarCloud Quality Gate passed! |
millems
added a commit
that referenced
this pull request
Apr 5, 2022
This improves the behavior introduced in #2989 if the customer is using a mock IMDS endpoint with aggressively short session durations.
millems
added a commit
that referenced
this pull request
Apr 5, 2022
This improves the behavior introduced in #2989 if the customer is using a mock IMDS endpoint with aggressively short session durations.
aws-sdk-java-automation
added a commit
that referenced
this pull request
Apr 18, 2024
…ab458244d Pull request: release <- staging/165afde2-4825-4e97-9e28-800ab458244d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by allowing services to validate credential expiration time during IMDS outages instead of assuming the SDK has access to the latest valid expiration time.
Additional changes: