Skip to content

Update GraalVM plugin version in the archetype-app-quickstart and sdk… #3013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 4, 2022

Conversation

zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Feb 3, 2022

…-native-image-test and update native-image.properties in netty-nio-client

Motivation and Context

Modifications

  • Bump up graalvm native image plugin version
  • Remove test dependencies from sdk-native-image-test
  • Remove obsolete args from native-image.properties in netty-nio-client

Testing

Tested locally by running the tests in sdk-native-image-test

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@zoewangg zoewangg requested a review from a team as a code owner February 3, 2022 18:11
@@ -16,7 +16,9 @@
<exec-maven-plugin.version>1.6.0</exec-maven-plugin.version>
<aws.java.sdk.version>${javaSdkVersion}</aws.java.sdk.version>
<slf4j.version>1.7.28</slf4j.version>
<graalvm.version>21.0.0</graalvm.version>
#if( $nativeImage == 'true')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this parameter resolved?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it was, had a hard time finding it. Thanks!

…-native-image-test and update native-image.properties in netty-nio-client
@zoewangg zoewangg force-pushed the zoewang/nativeImageVersionBump branch from 2039ec7 to 9d3ae54 Compare February 4, 2022 19:15
@zoewangg zoewangg enabled auto-merge (squash) February 4, 2022 22:38
@zoewangg zoewangg merged commit ed824ff into master Feb 4, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 4, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@zoewangg zoewangg deleted the zoewang/nativeImageVersionBump branch February 15, 2022 22:13
aws-sdk-java-automation added a commit that referenced this pull request May 1, 2024
…0122f3aba

Pull request: release <- staging/bdb7e117-4596-4a5c-9096-9350122f3aba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants