…Create nonexistent parent directories in AsyncResponseTransformer#toF #3018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile and ResponseTransformer#toFile.
12 tasks
zoewangg
commented
Feb 9, 2022
| this.fileChannel = invokeSafely(() -> createChannel(path)); | ||
| publisher.subscribe(new FileSubscriber(this.fileChannel, path, cf, this::exceptionOccurred)); | ||
| try { | ||
| createParentDirectoriesIfNeeded(path); |
There was a problem hiding this comment.
We probably have to clean up directories if it fails. Will update the PR
There was a problem hiding this comment.
It seems like it would be non-trivial to determine how many levels of parent directories were created and thus need to be cleaned up?
E.g., if /x/y/z/ exists but we try to create file /x/y/z/a/b/c/file, we would presumably only want to delete /a/b/c.
|
SonarCloud Quality Gate failed. |
|
Discussed with the team and decided to keep this logic in the TM instead. Closing the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ile and ResponseTransformer#toFile.
Motivation and Context
Currently, if the parent directory does not exist,
NoSuchFileExceptionis thrown, which is not a good customer experience.Modifications
Create nonexistent parent directories in
AsyncResponseTransformer#toFileand
ResponseTransformer#ToFileTesting
Add unit tests
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License