Skip to content

Add ClientOverrideConfiguration getter to SdkClientBuilder. (#3023) #3024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2022
Merged

Add ClientOverrideConfiguration getter to SdkClientBuilder. (#3023) #3024

merged 1 commit into from
Feb 23, 2022

Conversation

smswz
Copy link
Contributor

@smswz smswz commented Feb 11, 2022

Motivation and Context

Want to change client configuration overrides in multiple locations in code.
#3023

Modifications

Add new method to SdkClientBuilder interface and SdkDefaultClientBuilder

Testing

Created new test methods to ensure the returned ClientOverrideConfiguration matches what is input

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@smswz smswz requested a review from a team as a code owner February 11, 2022 21:10
@smswz smswz mentioned this pull request Feb 11, 2022
Merged
1 task
@smswz smswz force-pushed the master branch 7 times, most recently from 13d834b to bf1752d Compare February 22, 2022 20:37
@millems millems enabled auto-merge (squash) February 22, 2022 22:26
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@millems millems merged commit 4bf4d3a into aws:master Feb 23, 2022
forresthopkinsa added a commit to forresthopkinsa/micronaut-aws that referenced this pull request Apr 3, 2022
@forresthopkinsa
Bump aws-java-sdk-v2 to 2.17.162
d0d67da 
Test code change required due to:

aws/aws-sdk-java-v2#3024
@forresthopkinsa forresthopkinsa mentioned this pull request Apr 3, 2022
Merged
forresthopkinsa added a commit to forresthopkinsa/micronaut-aws that referenced this pull request Apr 11, 2022
@forresthopkinsa
Bump aws-java-sdk-v2 to 2.17.162
9eff055 
Test code change required due to:

aws/aws-sdk-java-v2#3024
@timyates timyates mentioned this pull request Apr 11, 2022
Closed
sdelamo pushed a commit to micronaut-projects/micronaut-aws that referenced this pull request Apr 11, 2022
@forresthopkinsa
build: bump aws-java-sdk-v2 to 2.17.162 (#1335)
fb88d01 
Test code change required due to:

aws/aws-sdk-java-v2#3024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millems millems millems approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smswz @millems