Adding an explicit isPresent check in SyncHttpChecksumInTrailerInterc… #3047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
reviewed
Feb 21, 2022
Comment on lines
93
to
101
| if (checksumSpecs == null | ||
| || !context.requestBody().isPresent() | ||
| || !HttpChecksumUtils | ||
| .isTrailerBasedChecksumForClientType( | ||
| executionAttributes, | ||
| context.httpRequest(), | ||
| ClientType.SYNC, checksumSpecs, | ||
| context.requestBody().isPresent(), | ||
| context.requestBody().map(requestBody -> requestBody.contentStreamProvider() != null).orElse(false))) { |
There was a problem hiding this comment.
This is a bit hard to read. Can we create a method for it?
…eptor to improve readibilty also to address sonarcloud bug
zoewangg
approved these changes
Feb 22, 2022
|
Kudos, SonarCloud Quality Gate passed! |
aws-sdk-java-automation
added a commit
that referenced
this pull request
May 24, 2024
…6f593adeb Pull request: release <- staging/2458f92e-473c-442c-b658-d956f593adeb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eptor to improve readibilty also to address sonarcloud bug
Motivation and Context
Modifications
Testing
Screenshots (if appropriate)
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License