Extension detected by customization flag #3067
Conversation
|
|
||
| @Test | ||
| public void bucketExists() { | ||
| assertThat(s3.doesBucketExist(BUCKET)).isTrue(); |
There was a problem hiding this comment.
v1 users rejoice!
It would be nice to test error conditions here as well. E.g., bucket exists but not owned by you.
There was a problem hiding this comment.
This is primitive for sure!
| @@ -159,5 +159,6 @@ | |||
| "createMethodParams": [ | |||
| "clientConfiguration" | |||
| ] | |||
| } | |||
| }, | |||
| "extensionInterface": "software.amazon.awssdk.services.s3.extensions.S3ClientExtensionMethods" | |||
There was a problem hiding this comment.
When we eventually support async extensions as well, do you foresee having 2 fields here? Would it maybe be simpler to just have the package prefix, and we can infer the rest? Or even a simple boolean if we can infer all of it.
There was a problem hiding this comment.
I think a name is better, at least a package name; leads to less inference. When I added this, I had in mind that we just slap Async on, but that's quite ugly. We could either infer both names or add a more complex structure.
|
Kudos, SonarCloud Quality Gate passed! |
…3659d5812 Pull request: release <- staging/39255d97-8c49-4ab7-a750-1473659d5812
No description provided.