[Hackathon] Add extension method: verifyBucketOwnership #3076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xtension-methods-8
cenedhryn
reviewed
Mar 3, 2022
|
|
||
| @Override | ||
| public void verifyBucketOwnership(String bucket) { | ||
| boolean isBucketOwner = s3.listBuckets() |
There was a problem hiding this comment.
What if there are many many buckets?
Is it possible to use a headBucket request, or is that too inconclusive?
There was a problem hiding this comment.
- The maximum number of buckets is 1,000.
listBucketsisn't a paginated operation. - Simply verifying access to a bucket via
headBucketdoesn't verify that we own it. The intent here is to verify that we own a bucket that we may be potentially writing to. - To use
headBucketwe would need to use theexpectedBucketOwnerparameter, but the difficulty here is that we don't necessarily know the caller's AWS Account ID. However,listBucketsworks as a clever workaround here because it "returns a list of all buckets owned by the authenticated sender of the request".
There was a problem hiding this comment.
Sounds good! Thanks for clarifying.
cenedhryn
approved these changes
Mar 3, 2022
|
SonarCloud Quality Gate failed. |
aws-sdk-java-automation
added a commit
that referenced
this pull request
Jun 18, 2024
…679627e5f Pull request: release <- staging/1ef9dcd3-af44-4770-8f97-350679627e5f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.