Make API Gateway integ test's deleteRestApi more reliable & best-effort #3083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joviegas
reviewed
Mar 7, 2022
| DELETE_RATE_LIMITER.getValue().acquire(); | ||
| try { | ||
| apiGateway.deleteRestApi(DeleteRestApiRequest.builder().restApiId(restApiId).build()); | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
Query : Why aren't we catching just the specific exception TooManyRequestsException here?
There was a problem hiding this comment.
I wanted to catch any potential transient failure (TooManyRequestsException, 500, 503, etc.) and not ever fail the tests on those occurring. But I agree it could be potentially dangerous to catch something like a 400.
I'll assume that most transient failures will be covered by retries and change this to just catch TooManyRequestsException.
joviegas
approved these changes
Mar 7, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
aws-sdk-java-automation
added a commit
that referenced
this pull request
Jun 20, 2024
…e942cb256 Pull request: release <- staging/5f8bcdb1-da45-49cf-ac7f-419e942cb256
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License