Bump CRT version to 0.16.10, which contains M1 support #2942 #3209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
commented
May 23, 2022
| @@ -67,6 +67,7 @@ private S3CrtAsyncHttpClient(Builder builder) { | |||
| .withCredentialsProvider(s3NativeClientConfiguration.credentialsProvider()) | |||
| .withClientBootstrap(s3NativeClientConfiguration.clientBootstrap()) | |||
| .withPartSize(s3NativeClientConfiguration.partSizeBytes()) | |||
| .withComputeContentMd5(true) | |||
There was a problem hiding this comment.
We had to make this change because CRT has pushed fixes to honor this config in latest version in this PR awslabs/aws-crt-java#486. In previous versions, MD5 is always enabled and computeContentMd5 is default to false in the CRT Java binding. We will disable it once we have flexible checksum support.
There was a problem hiding this comment.
Is it imported to brazil, or will this block our build to live?
There was a problem hiding this comment.
It should not block our build to live because this config is available in previous CRT version as well (just not honored). I'll check with CRT team to see when they will do an import.
millems
approved these changes
May 23, 2022
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Bump CRT version to 0.16.10, which contains M1 support #2942
Testing
Running test suites nowinteg tests and stability tests passed