Add missing CopyableBuilder interfaces and fixed buggy ones. #3267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cenedhryn
reviewed
Jun 24, 2022
Comment on lines
164
to
168
| builders.put(obj.getClassName(), obj); | ||
| builderParents.put(obj.getClassName(), | ||
| Stream.concat(Arrays.stream(parentInterfaces), Arrays.stream(obj.getSuperClasses())) | ||
| .map(JavaClass::getClassName) | ||
| .collect(Collectors.toSet())); |
There was a problem hiding this comment.
It looks like the same code will get executed for any matching i. Is there a way to break it out of the loop?
There was a problem hiding this comment.
Technically it might be slower this way with it outside of the loop, since most classes won't have a matching value and none will have multiple matching values (enforced in the interface visitation logic).
core/annotations/src/main/java/software/amazon/awssdk/annotations/ToBuilderIgnoreField.java
Show resolved
Hide resolved
core/auth/src/main/java/software/amazon/awssdk/auth/credentials/ProcessCredentialsProvider.java
Show resolved
Hide resolved
…ed when ToCopyableBuilder.toBuilder is invoked. Also fixed any violations that rule found.
millems
force-pushed
the
millem/master/copyable-builder-validation
branch
from
e30f139 to
922ccc3
Compare
cenedhryn
approved these changes
Jun 24, 2022
|
SonarCloud Quality Gate failed. |
This was referenced Jun 27, 2022
aws-sdk-java-automation
added a commit
that referenced
this pull request
Sep 20, 2024
…c36f85568 Pull request: release <- staging/317dd499-2aca-470a-9809-3e2c36f85568
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CopyableBuilder and ToCopyableBuilder interfaces to credential providers. Also added spotbugs rule to validate that these and all other toBuilder methods are correct. Fixed any issues found with existing methods.