Skip to content

Set Accept header for UrlConnectionHttpClient #3294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 12, 2022
Merged

Set Accept header for UrlConnectionHttpClient #3294

merged 2 commits into from
Jul 12, 2022

Conversation

zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Jul 12, 2022 •
edited
Loading

Modifications

Set the Accept header for UrlConnectionHttpClient because the default one does not comply with RFC 7231. See https://bugs.openjdk.org/browse/JDK-8163921

The change upstream has only been released in JDK 19. openjdk/jdk@28796cb

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@zoewangg zoewangg requested a review from a team as a code owner July 12, 2022 01:28
@zoewangg zoewangg force-pushed the zoewang/httpUrlConnectionAcceptHeader branch from 6c5f102 to 77d5330 Compare July 12, 2022 03:20
@zoewangg zoewangg force-pushed the zoewang/httpUrlConnectionAcceptHeader branch from 77d5330 to d39f57f Compare July 12, 2022 19:53
@zoewangg zoewangg enabled auto-merge (squash) July 12, 2022 21:01
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@zoewangg zoewangg merged commit cfacbd8 into master Jul 12, 2022
@zoewangg zoewangg deleted the zoewang/httpUrlConnectionAcceptHeader branch July 12, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagnir dagnir dagnir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zoewangg @dagnir