Implement Service Endpoint Metric #3470

dave-fn · 2022-10-07T18:29:17Z

Motivation and Context

Provide a service endpoint metric to match the SDK v1 behavior as described with issue 2579.

Modifications

Created SERVICE_ENDPOINT in CoreMetric for returning an URI.
Modified BaseClientHandler to report this new metric once an HTTP request has been built.

Testing

Tested under CoreMetricsTest. Also added assert to ignored test in BaseAsyncCoreMetricsTest.

Screenshots (if appropriate)

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Checklist

I have read the CONTRIBUTING document
Local run of mvn install succeeds
My code follows the code style of this project
My change requires a change to the Javadoc documentation
I have updated the Javadoc documentation accordingly
I have added tests to cover my changes
All new and existing tests passed
I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

I confirm that this pull request can be released under the Apache 2 license

dave-fn · 2022-10-07T18:30:51Z

core/sdk-core/src/main/java/software/amazon/awssdk/core/internal/handler/BaseClientHandler.java

+        try {
+            URI endpoint = new URI(request.protocol(), request.host(), null, null);
+            executionContext.metricCollector().reportMetric(CoreMetric.SERVICE_ENDPOINT, endpoint);
+        } catch (URISyntaxException e) {
+            throw new IllegalArgumentException(e);
+        }
