Skip to content

Docs: Clarifying BatchWriteItem limits #3519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 31, 2022

Conversation

debora-ito
Copy link
Member

Motivation and Context

Based on feedback, fixes #3476.

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@debora-ito debora-ito requested a review from a team as a code owner October 25, 2022 23:34
@L-Applin L-Applin assigned L-Applin and unassigned L-Applin Oct 28, 2022
@@ -168,6 +168,9 @@ default BatchGetResultPageIterable batchGetItem(Consumer<BatchGetItemEnhancedReq
* The additional configuration parameters that the enhanced client supports are defined
* in the {@link BatchWriteItemEnhancedRequest}.
* <p>
* A single call of BatchWriteItem has the same limit of items of the low-level DynamoDB API BatchWriteItem operation,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would write

     * A single call ***to*** BatchWriteItem has the same limit of items ***as*** the low-level DynamoDB API BatchWriteItem operation,
     * considering all items across all WriteBatches.

@debora-ito debora-ito force-pushed the dynamodb-doc-improvements branch from 1e8f823 to 6240565 Compare October 28, 2022 18:59
@debora-ito debora-ito enabled auto-merge (squash) October 31, 2022 21:54
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@debora-ito debora-ito merged commit 639e57c into aws:master Oct 31, 2022
aws-sdk-java-automation added a commit that referenced this pull request Dec 12, 2024
…05e4d3d67

Pull request: release <- staging/4dd720f1-8e2c-4099-82bd-de105e4d3d67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing details on max batch size for batchWriteItem operations in DynamoDbEnhancedClient
2 participants