Validate signer client options based on authtype #3579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue with the client option validation where the client builder is incorrectly validating that a value for the SIGNER option is present, even when it's not required (because the service does not use AWS auth). This change only does the appropriate validations based on the authtypes present in the service model.
dagnir
force-pushed
the
dongie/fix-bearer-signer-npe
branch
from
af4667e to
b11b3bd
Compare
dave-fn
reviewed
Dec 1, 2022
|
Kudos, SonarCloud Quality Gate passed! |
zoewangg
reviewed
Dec 1, 2022
| "The 'overrideConfiguration.advancedOption[SIGNER]' must be configured in the client builder."); | ||
| } | ||
|
|
||
| if (AuthUtils.usesBearerAuth(model)) { |
There was a problem hiding this comment.
Should it be else if? Can they use both aws auth and bearer auth?
There was a problem hiding this comment.
Yes they can. For example, the service signatureVersion has v4 but also includes one operation that uses bearer.
zoewangg
approved these changes
Dec 1, 2022
aws-sdk-java-automation
added a commit
that referenced
this pull request
Jan 17, 2025
…fd9248d76 Pull request: release <- staging/c576f37d-5dca-45a5-99ad-c78fd9248d76
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This fixes an issue with the client option validation where the client builder is incorrectly validating that a value for the SIGNER option is present, even when it's not required (because the service does not use AWS auth).
Modifications
This change only does the appropriate validations within the builder based on the authtypes present in the service model.
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License