Skip to content

Fix ordering of *contexParams #3700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 13, 2023
Merged

Fix ordering of *contexParams #3700

merged 5 commits into from
Feb 13, 2023

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented Jan 18, 2023 •
edited
Loading

Motivation and Context

Per the implementation standard, the order in highest precedence is

  • static context params
  • context params
  • client context params

Modifications

Testing

  • unit tests
  • integ tests

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir
Fix ordering of *contexParams
89b7136 
Per the implementation standard, the order in highest precedence is

 - static context params
 - context params
 - client context params
@dagnir dagnir force-pushed the dongie/fix-param-resolution-ordering branch from 8caab68 to 89b7136 Compare January 18, 2023 03:18
@dagnir dagnir marked this pull request as ready for review January 18, 2023 04:13
@dagnir dagnir requested a review from a team as a code owner January 18, 2023 04:13
@dagnir dagnir enabled auto-merge (squash) February 10, 2023 17:18
@dagnir dagnir merged commit 1c40b3c into master Feb 13, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.3% 83.3% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoewangg zoewangg zoewangg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dagnir @zoewangg