Skip to content

Minor updates to PR #3773 #3814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Minor updates to PR #3773 #3814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbb4c04
Simplify hashCode and equals for ResolveIdentityRequest
gosar Mar 6, 2023
c2d4465
Fix doc link about AWS access keys
gosar Mar 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions core/auth/src/main/java/software/amazon/awssdk/auth/credentials/AwsBasicCredentials.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@
import software.amazon.awssdk.utils.Validate;

/**
* Provides access to the AWS credentials used for accessing AWS services: AWS access key ID and secret access key. These
* credentials are used to securely sign requests to AWS services.
* Provides access to the AWS credentials used for accessing services: AWS access key ID and secret access key. These
* credentials are used to securely sign requests to services (e.g., AWS services) that use them for authentication.
*
* <p>For more details on AWS access keys, see:
* <a href="http://docs.amazonwebservices.com/AWSSecurityCredentials/1.0/AboutAWSCredentials.html#AccessKeys">
* http://docs.amazonwebservices.com/AWSSecurityCredentials/1.0/AboutAWSCredentials.html#AccessKeys</a></p>
* <a href="https://docs.aws.amazon.com/general/latest/gr/aws-sec-cred-types.html#access-keys-and-secret-access-keys">
* https://docs.aws.amazon.com/general/latest/gr/aws-sec-cred-types.html#access-keys-and-secret-access-keys</a></p>
*
* @see AwsCredentialsProvider
*/
Expand Down
5 changes: 2 additions & 3 deletions ...dentity-spi/src/main/java/software/amazon/awssdk/identity/spi/ResolveIdentityRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,13 @@ public boolean equals(Object o) {
if (o == null || getClass() != o.getClass()) {
return false;
}

ResolveIdentityRequest that = (ResolveIdentityRequest) o;
return Objects.equals(properties, that.properties);
return properties.equals(that.properties);
}

@Override
public int hashCode() {
return 31 + Objects.hashCode(properties);
return Objects.hashCode(properties);
}

public static final class Builder implements SdkBuilder<Builder, ResolveIdentityRequest> {
Expand Down